Testing UI

[raconzor]

I believe it is now sufficiently full-featured so as to be useful. It may still be buggy - I welcome any feedback on functionality or UI. One thing to watch out for is it does not currently default glyphs.

A save/load feature is high on my list, but I still have some things to do to prepare my toon for Cata so ... I'm not sure how far I will get on that list.

Other TODOs - clean up the UI, make the reforged values visible somewhere, add talent comparions to result area.

[dazer]

Since I don't know how to merge your commists into a new branch in my fork to modify it, I'm putting up here http://www.megaupload.com/?d=62D42D5Z a populated ui_data.py. I took items ranging from 333 to 372 iLvl; trinkets I took were all those that our engine supports. I took out items with random enchants and commented out some never-to-be-used weapons (slow off-hands).

Notes:

• Cogwheels: I think they are not supported, so the eng helmet won't work to its fullest
• Fist set: since the other fist is str based, slow and the proc is not modeled, I only included the agi one.
• Tier set: I don't know how/if that is supported, so I left it in comments instead of inside the items.
• Weapons: I took the liberty to add the speed and type to their names so we have it easier when choosing through them.
• Parsing: I usually have trouble parsing floating points, so some of the values could potentially be wrong. I took special care to handle it but I'm not 100% sure of them (this affects weapon speed and avg damage).
• Format: I wrote them all in one line each; if you feel I should follow the one line per stat/proc/whatever let me know and I'll fix it promptly.
• Filter: 333 iLvl may be a little too low, if you think I should up it a notch don't hesitate to tell me so.
• Some items have 2 yellow gems, since the sockets are stored in lists I dont see a workarrond this. There are not too many though, so no big deal.

reuploaded file: one item was missing

[raconzor]

Committed the file with a couple small changes. Added support for tier11 to the ui. 2 yellow gems - hmm, that's definitely on the list

[Aldriana]

Would it make sense to move this into a subdirectory of its own rather than leaving it in the top level?

[dazer]

There's a parsing error that I somehow let through in the file I uploaded: every item with sockets is holding a 'mastery': number_of_sockets string. I'll upload a new file once I get home.

[raconzor]

Subdirectory: I've had issues running anything from other than the root directory due to include paths - I'll take a look at this again tonight.

Parsing issue: I can find-replace that easily enough myself.

[raconzor]

One other thought - I really don't like the un-ordered appearance of the gear in the app. The only way I know to allow specifying an arbitrary (non-alphabetic) order is to keep all the item names in a separate ordered list. Thoughts? For me this definitely goes after a save/load feature and allowing multiple same-color gems.

[julienp]

Raconzor: here's how I changed the tests scripts in the packaging branch: https://github.com/julienp/ShadowCraft-Engine/blob/packaging/scripts/assassination.py Should work for the UI too.

[raconzor]

These updates are incorporated in the latest commits.

[Aldriana]

Is this ready to be pulled, then?

[raconzor]

Yes I think so. As a check, I plugged the same gear/glyphs into my version and julien's - they came out ~6 dps different which I think is believable as compounded rounding error.