search

Aldriana / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
37 stars 22 forks source link

4pc T12/proc interaction #86

Closed Aldriana closed 13 years ago

Aldriana commented 13 years ago

It appears that the 4pc T12 bonus is not being applied to trinket procs. Is this intentional, or an oversight?

(To be clear: its simple enough to change the behavior, I just want to make sure I didn't miss testing somewhere that indicates that it shouldn't. Because my immediate instinct is to say that it should.)

dazer commented 13 years ago

It's intentional but I didn't document why: I tend to lean towards the underestimate side of things and was waiting to get the set to test it myself. Feel free to include it; should be easy enough.

Edit: In fact I was expecting to include it with a method to compute interaction between trinkets (and white crit caps from procs and trinket synergy too); most obvious case is if hungerer and matrix are equiped: I would expect matrix to proc as haste 25% of the time on assassination builds (not that it matters with current EP anyway) and was trying to come up with a global solution —with little to no success I must say—.

Aldriana commented 13 years ago

Yeah, I think its the right thing to do to include it, because whether it snapshots or provides a persistent buff, its a good approximation; the only way it doesn't is if it somehow ignores rating stats completely which strikes me as unlikely (though not impossible). We can always revert it if I turn out to be wrong, but I think its more likely to be right than not, so for the moment I'm going to change it.