dazer
commented
13 years ago On the unheeded warning changes: I left all the code in place (in case they design such a nightmare again) and only commented the overrriden method. I left everything else unchanged: as much recursiveness it presents, it's just a method call that returns 0 all the time (profiling the code with every caller gone didn't present much of a performance increase). Do we want the whole thing gone for good?
Munching as discussed on the EJ thread. The value of the set decreases: not much, but noticeably nonetheless. It's still not modifying the set damage with KsP/BG (find weakness fitted better). I have a couple ideas about the implementation: either 1- Run a hash map (with weighted burning_wounds damage for each ability) along with damage_breakdown and compute in
combat_dps_breakdown()the implications of both damage boosts; or 2- have damage_breakdown take a third value for each ability{'damage_key':[average_dps, crit_contribution, set_damage], ...}and decouple it in all four dps_breakdown methods. Any preference or better idea?About the hemo dot: I got a PM explaining that the dot doesn't reset the timer even when overwriting (it's in the mechanics thread too, which I missread). Value of the glyph while hemoing every 24+ seconds remains unchanged; overwriting the dot, produces better outcomes than before (>650 dps), but yet not enough for hemo to be usefull as the main cpg.