Ale0430 / MiniBuoy-App

Its another app
GNU General Public License v3.0
0 stars 0 forks source link

Quicker analysis #14

Closed cailadd90 closed 1 year ago

cailadd90 commented 1 year ago

Added a new argument to use a proportion of the data in detecting abrupt shifts. Testing showed using 25% of the data results in marked improvements in speed (i.e. chop = 0.25). Default is currently to use all the data (chop = 1), but maybe the default should be 25%.

mcwimm commented 1 year ago

@cailadd90 Is "chop" a user input, i.e., something displayed is "Custom Settings"?

mcwimm commented 1 year ago

Not working when chop = 0

cailadd90 commented 1 year ago

Not working when chop = 0

Sorry, I should have clarified. 'chop' represents the proportion of data to be used in searching for partially inundated cases. 1 = all the data, 0 = no data (so the analysis won't run with no data). Happy to use a better system, e.g. a binary choice: 'All' (chop = 1) or 'Reduced' (chop = 0.25)?

mcwimm commented 1 year ago

Ah, ok :) Now, it should work. Default is 50%, also throwing a "warning" to inform the user that not all data has been used. Please check wording of the warning :)

cailadd90 commented 1 year ago

Ah, ok :) Now, it should work. Default is 50%, also throwing a "warning" to inform the user that not all data has been used. Please check wording of the warning :)

Nice one!

cailadd90 commented 1 year ago

It's working well, very happy to see how much the code speeds up.

I would say the warning isn't required, as it's not that less data is being produced. It's simply that the precision of partially inundated cases may reduce, but testing has shown this to have a minimal effect (I will add this to the Mini Buoy handbook...).

Some suggested changes to the custom settings titles:

The message displayed when hovering over 'proportion data' could have another sentence added: "Using less data increases the speed of the analysis and has a minimal effect on the accuracy of detecting partially inundated cases."

mcwimm commented 1 year ago

Partial data search