Simpler custom settings and works across all designs

[cailadd90]

What's changed

server.R

• added the 'design' argument so that wave orbital velocity stats are only presented if B4+ is used

fun_ui_hydrology.R

• default gaps and full are now in hours
• default part is now a proportion of the start and end of each individual inundation event. This was changed because users would probably have had to input a unique part value with every unique dataset. A proportional value of 25% seems to work well in general.
• Modified the custom labels and pop-up text to reflect changes in the points above

fun_hydrology.R

• Updated the default values (see previous points)
• chop is now fixed to 0.25
• rate is calculated using difftime to ensure the units are consistently in seconds
• added if statements to only run steps necessary for calculating wave orbital velocity if B4+ is being used
• for Pendant, we're aggregating into 2 minutes, not 10 min
• gaps and full are corrected depending on the sampling rate of the data
• search windows for partial inundation are now done as a proprtion of each inundation event, rather than a single value for the whole dataset
• subsetting data is not done for Pendant, as sampling rate is lower
• Abrupt shift detection fails if there are less than 5 data points in the search window. A new code chunk added to exclude short windows from analysis. A warning is needed here, as values in the search window will default to full inundation
• Corrected the calibration equations to convert tilt to current velocity for B4 and Pendant
• Corrected the FullCheck test that checks if a day has a full dataset
• updated summary / daily / event / text / comparison statistics to only include wave orbital velocity if B4+ is used

[mcwimm]

👍 the code works. However, I'm not quite sure about the content-related aspects but this is your part :)

Minor comment: In text we use always the plural of 'days', e.g., "The longest window of opportunity was 1 days, which is too short to expect natural seedling establishment at this site." We could cange this to "day(s)".

[cailadd90]

Yes - good idea! Simpler for now than adding more if statements to account for this. Can you amend?

[mcwimm]

Yes - good idea! Simpler for now than adding more if statements to account for this. Can you amend?

Changed. Ready to merge?

[cailadd90]

Nice - ready to merge :)