Cosmetic fixes - Githubissues

Ale0430 / MiniBuoy-App

Its another app

GNU General Public License v3.0

0 stars 0 forks source link

Cosmetic fixes #42

Closed cailadd90 closed 1 year ago

cailadd90 commented 1 year ago

Further modifications to layout and text to improve usability.

mcwimm commented 1 year ago

@cailadd90 the file MinibuoyIntro_3.md is missing. Could you please upload the file?

cailadd90 commented 1 year ago

@cailadd90 the file MinibuoyIntro_3.md is missing. Could you please upload the file?

Strange, is it not in #42 in the man folder?

cailadd90 commented 1 year ago

Oh I can see it's not there on GitHub... it says "everything's up to date" on my system - not sure why it didn't upload. I'll do it manually?

mcwimm commented 1 year ago

It's probably not in the change list of git. Use git add ... (https://www.atlassian.com/git/tutorials/saving-changes#:~:text=The%20git%20add%20command%20adds,until%20you%20run%20git%20commit%20.) to add it.

cailadd90 commented 1 year ago

I answered my own question by just adding it manually - is that OK?

mcwimm commented 1 year ago

I answered my own question by just adding it manually - is that OK?

That's perfect! Thanks.

mcwimm commented 1 year ago

For some reason, the comaprison - summary text is not working anymore. Just checked, in the master it's still without error. Could you check this?

cailadd90 commented 1 year ago

Ooops! I think I know the problem - I removed the comparison of no. of inundation events from the summary table, but this has affected the text. I'll fix that now

cailadd90 commented 1 year ago

Ooops! I think I know the problem - I removed the comparison of no. of inundation events from the summary table, but this has affected the text. I'll fix that now

Ok in fun.hydrology.R, get.comparison.text() function, "Inundation proportion" needs to change to "Inundation duration" in 2 instances - then the bug is fixed.

I tried pushing the change, but I've messed up my branches somehow.... I have a meeting I need to prepare for 11:00 (UK time) so need to work on that now. Feel free to make this change? I'll try fixing things on my end after 11:00.

mcwimm commented 1 year ago

comparison

I replaced the strings but it's still not working for me. Will wait until you're done with your meeting...

cailadd90 commented 1 year ago

comparison

I replaced the strings but it's still not working for me. Will wait until you're done with your meeting...

Pushed a commit, and it's working for me now. Want to check again?

mcwimm commented 1 year ago

Works!