search

Ale0430 / MiniBuoy-App

Its another app
GNU General Public License v3.0
0 stars 0 forks source link

Small fixes #56

Open mcwimm opened 7 months ago

mcwimm commented 7 months ago

Several small fixes - @cailadd90 can you please test if everything still works?

  1. After I updated my R, the data upload did not work. Please check if it still works now with your R version (btw: which R version do you use?)
  2. The parameter comparison plot looked a bit strange. It seems that the plotly/shiny rendering cannot handle grouped boxplots. So I've removed plotly rendering for this plot.
  3. There was a bug when saving figures but no data was uploaded. this should work now

After my R update, an external R graphics device opens when I start the app. Is this happening to you? Not sure if this is code related or an issue with my settings. @Ale0430 Can you test this as well?

Ale0430 commented 4 months ago

Several small fixes - @cailadd90 can you please test if everything still works?

  1. After I updated my R, the data upload did not work. Please check if it still works now with your R version (btw: which R version do you use?)
  2. The parameter comparison plot looked a bit strange. It seems that the plotly/shiny rendering cannot handle grouped boxplots. So I've removed plotly rendering for this plot.
  3. There was a bug when saving figures but no data was uploaded. this should work now

After my R update, an external R graphics device opens when I start the app. Is this happening to you? Not sure if this is code related or an issue with my settings. @Ale0430 Can you test this as well?

It's happening now. I'm on R.4.3.3 for Windows. On data upload (even with default data) the summary table returns an error, but I can still click on "Use Data" the data loads and hydrodynamics is processed as normal.

Running on Mac R. 4.1.2 there are no issues

Ale0430 commented 4 months ago

Issue solved on branch 'small_fixes'

cailadd90 commented 2 months ago

Just to confirm - for me (macOS Sonoma + R version 4.2.3 ), uploading works, am able to save figures, and no external apps are opening. Are these problems persisting with you @mcwimm ?

If not, are we good to merge into master? This would be good - a colleague is struggling with the current version as it's not letting you upload another datasets on top of the old one (this branch fixes that problem).