fix: guard against empty log captures

AleG94 / mocha-suppress-logs

Suppress console output of successful mocha tests

MIT License

12 stars 3 forks source link

fix: guard against empty log captures #13

Closed tripodsan closed 5 months ago

tripodsan commented 5 months ago

fixes #12

tripodsan commented 5 months ago

Hi @AleG94 , any chance that we can get this PR merged? thanks.

AleG94 commented 5 months ago

Hi @tripodsan, unfortunately this pull request only fixes a handful of use cases but it's not a solution that works on every reporter so I reverted back to intercepting console methods instead of stdout and stderr and released 0.5.0.

Would you mind confirming that it works properly for you as well?

tripodsan commented 5 months ago

thank @AleG94 for the fix, it works. but I think the clone dependency should not be a dev dependency. now I get:

✖ ERROR: Error: Cannot find module 'clone'
Require stack:
- /Users/.../.../node_modules/mocha-suppress-logs/lib/log-capture.js
- /Users/.../.../node_modules/mocha-suppress-logs/index.js

AleG94 commented 5 months ago

Right, 0.5.1 released with the fix!

tripodsan commented 5 months ago

thank you for the quick turnaround.