search

AleSpero / ExpandableCardView

Simple expandable CardView for Android.
Apache License 2.0
689 stars 88 forks source link

Dark theme #49

Open ShanuDey opened 4 years ago

ShanuDey commented 4 years ago

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

Stjin commented 4 years ago

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

This library was updated over a year ago. Not sure if it's still being maintained. I forked this project and added this already.

ShanuDey commented 4 years ago

I tried your fork, but it has an error.

ERROR: Failed to resolve: com.github.Stjinchan:ExpandableCardView:1.1.4 Show in Project Structure dialog Affected Modules: app

Do u know any solution to fix this? @

Stjin commented 4 years ago

I tried your fork, but it has an error.

ERROR: Failed to resolve: com.github.Stjinchan:ExpandableCardView:1.1.4 Show in Project Structure dialog Affected Modules: app

Do u know any solution to fix this? @

Please add Jitpack to your build.gradle

AleSpero commented 4 years ago

Hello everyone,

The library unfortunately is not actively mantained due to time issues. However, @Stjinchan if you are willing to fix this issue feel free to open a PR and i'll review it and eventually merge it into the main branch.

Kind regards :)

Alessandro

Stjin commented 4 years ago

Hello everyone,

The library unfortunately is not actively mantained due to time issues. However, @Stjinchan if you are willing to fix this issue feel free to open a PR and i'll review it and eventually merge it into the main branch.

Kind regards :)

Alessandro

Fixed already with some other issues. I'll PR these later this week. Currently trying to fix 1 more annoying bug I can't seem to fix :P

ShanuDey commented 4 years ago

@Stjinchan The expanding arrow color should change according to the theme. In the dark theme, it gets camouflaged.

Stjin commented 4 years ago

@Stjinchan The expanding arrow color should change according to the theme. In the dark theme, it gets camouflaged.

Please create an issue on my fork as I am mainly maintaining that one. I'll fix it tonight.

bytss commented 2 years ago

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

This library was updated over a year ago. Not sure if it's still being maintained. I forked this project and added this already.

Thank you Sir!