search

AlecAivazis / survey

A golang library for building interactive and accessible prompts with full support for windows and posix terminals.
MIT License
4.08k stars 350 forks source link

v2: unselected options are bold, selected option normal formatted #231

Closed ahmetb closed 5 years ago

ahmetb commented 5 years ago

After migrating to v2, non-highlighted options are bold, focused option is non-bold. Seems unintuitive. Is this expected?

image

AlecAivazis commented 5 years ago

Yea that definitely doesn't look right. Let me check

AlecAivazis commented 5 years ago

Huh, so apparently the v1 template was also bolding that text... Either way, I agree with you that it's not very pretty. I'll open a PR now

ahmetb commented 5 years ago

hmm I don't think this was happening in v1.

AlecAivazis commented 5 years ago

You can see the hb at the end of the line here: https://github.com/AlecAivazis/survey/blob/v1/select.go#L56

ahmetb commented 5 years ago

my bad. just checked 1.8.3, looks like it was making all options bold (incl. the focused one), so that's why I didn't notice it earlier.