Closed execjosh closed 4 years ago
So, main
is redeclared inside some packages (i.e., v2/{test,exaple}s/
), which is causing go get -v -t ./...
(executed via travis_install_go_dependencies 1.12 -v
) to fail. As far as I can tell, this problem has nothing to with the changes introduced by this pull request.
Ooo this is a much cleaner solution than what I've tried to do to fix this. Nice!
I fixed the CI issue in the v1
branch, will port that over now.
hey @execjosh! If you rebase onto the current master, you should pick up the fixes. Thanks for being patient
I think this also addresses an issue that @mritd ran into
@AlecAivazis Great! Thanks for taking a look 😄 Hmm, I needed to go mod vendor
it, otherwise the tests wouldn't run with GOFLAGS='-mod=vendor'
set. Some of the previously vendored packages disappeared, though 🤷♂ Let me know if you prefer to just add golang.org/x/text
and not remove the others.
Great! Glad I was able to help 😄
CJK runes are rendered using two cells in the console. So, look at the rune to decide how many cells to move during rendering.
I am not sure how to test this, though.
This fixes #272.