search

AlecAivazis / survey

A golang library for building interactive and accessible prompts with full support for windows and posix terminals.
MIT License
4.08k stars 351 forks source link

Put cursor on selected line #305

Closed shindere closed 2 years ago

shindere commented 3 years ago

This issue stems from a discussion started at

https://github.com/cli/cli/issues/1085

and in particular comment

https://github.com/cli/cli/issues/1085#issuecomment-705164274

Would it please be possible to patch the library so that the cursor gets placed on the selected line? It would make it more usable from a braille display which generally follows the cursor.

AlecAivazis commented 3 years ago

Absolutely! Thank you so much for bringing this up. I had NO idea that's all it took to work better with braille displays.

shindere commented 3 years ago

Alec Aivazis (2020/11/02 13:31 -0800):

Absolutely! Thank you so much for bringing this up. I had NO idea that's all it took to work better with braille displays.

Many thanks for your positive feedback!

This kind of knowledge is indeed not very widespread.

If you implement the feature and need testing, please feel free to contact me either here or by e-mail directly: Sebastien.Hinderer@inria.fr

Thanks!

vilmibm commented 3 years ago

@AlecAivazis Hiya!

I'm hoping to take on this work on behalf of the GitHub CLI team; let me know if there are pitfalls or other issues I should be aware of before I dig it.

AlecAivazis commented 3 years ago

Awesome!! I’m super excited to hear that @vilmibm. Nothing specific comes to mind but please let me know if you need any guidance.