search

AlecAivazis / survey

A golang library for building interactive and accessible prompts with full support for windows and posix terminals.
MIT License
4.07k stars 351 forks source link

fix cursor updating in windows #370

Closed vilmibm closed 2 years ago

vilmibm commented 2 years ago

tl;dr cursor was not updating in windows; this fixes it (tested with NVDA)

long version: i noticed that the argument to PreviousLine was unused; I mindlessly made it -1 as a mental TODO to investigate why it took a parameter at all. I realized that the parameter was used in the windows version of the cursor code, but apparently didn't go back and fix the argument (I totally thought I had and I'm not sure what happened since I did do windows QA at some point and it worked).

billygriffin commented 2 years ago

@AlecAivazis I know you've been busy, but if you're able to get this in soon, we'd really appreciate it. We're hoping to get a new version bump into GitHub CLI as soon as you're comfortable so the accessibility improvements are available to all our users.

AlecAivazis commented 2 years ago

Ah, darn! Thanks for the quick fix!

AlecAivazis commented 2 years ago

This is now released in v2.3.1

billygriffin commented 2 years ago

Omg @AlecAivazis that's amazing, thank you SO much. ❤️ ✨

vilmibm commented 2 years ago

thank you!!! sorry for the hassle