AlecThomson / arrakis

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

RMSs passed in as linmos weights #45

Closed tjgalvin closed 11 months ago

tjgalvin commented 11 months ago

I found this when doing my adventuring on the high seas with flint, but it looks like to me that passing RMSs through as weights into linmos is not the right thing to do. We should be passing in the inverse RMS squared, or at the very least the inverse RMS. I believe the higher the weight, the more preference linmos gives to that image. So, lower RMSs (i.e. better image) are actually treated with less importance.

I will confirm this is the correct behavior next day or two. Putting here so the beer I drink later doesn't make me forget.