AlecksJohanssen / Ruby-on-Rails-Blog-Prework

0 stars 0 forks source link

Ruby on Rails Prework Assignment #1

Open AlecksJohanssen opened 8 years ago

AlecksJohanssen commented 8 years ago

Hello Coderschool, here is my complete prework assignment. /cc @coderschoolreview @chug2k @harley

coderschoolreview commented 8 years ago

Hi @AlecksJohanssen, 👍 thanks for giving this a try even though you didn't have much time. Some cool things:

💭 A couple of areas to improve:

Overall, this app has potential but we'd like to see some more effort put into it. Let us know if you have any questions and we are here to help!.

AlecksJohanssen commented 8 years ago

Hello @coderschoolreview , Thank you for the feedback, I will put more of my effort in it. Thank you for tuning in :P

harley commented 8 years ago

In addition to what the TA said above, I have some quick feedback: make sure you fix the spacing between the UI elements (e.g. buttons). Pay attention to CSS padding and margin. There are a lot of UI inconsistencies at the moment. For example, fix these issues:

AlecksJohanssen commented 8 years ago

@harley Thank you for the feedback sir, I will fix it as soon as possible.

AlecksJohanssen commented 8 years ago

Hello Mr @harley @coderschoolreview .I just updated my prework, I have fixed the UI Inconsistencies. Could you please check it out again ? Thank you.

AlecksJohanssen commented 8 years ago

Hello Mr @harley @coderschoolreview , I've just finished my new update. Could you guys please check it out for me ?.

Thank you.

coderschoolreview commented 8 years ago

Hi @AlecksJohanssen, thanks for all the efforts so far. Please check your email for the acceptance to the next Ruby class. Look forward to working with you!