AlekKwek18 / pe

0 stars 0 forks source link

Insufficient validation for phone number #4

Open AlekKwek18 opened 4 days ago

AlekKwek18 commented 4 days ago

The program accepts phone numbers like 000 or 00000000 which is not a valid phone number.

Steps to reproduce add n/obama tan t/acl tear e/obamatan@example.com a/Newgate Prison p/000 t/ankle sprain OR add n/obama tan t/acl tear e/obamatan@example.com a/Newgate Prison p/00000000 t/ankle sprain

Output

Screenshot 2024-11-15 at 4.44.55 PM.png

Screenshot 2024-11-15 at 4.45.27 PM.png

Other info also happens in edit command

nus-pe-script commented 14 hours ago

Team's Response

Thank you for raising this issue.

However, the acceptance of numbers like 000 as a valid input falls outside the scope of this software as our intended target users are not limited to the ones in Singapore and validating phone numbers to cover every country is a very complex task and will reduce our ability to develop other features.

Moreover, even if it occurs, the input 000 would typically not cause significant harm or disrupt the product's functionality beyond a minor inconvenience of validating data.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]