AleksandrHovhannisyan / aleksandrhovhannisyan.com

My online resume and blog, created with 11ty, Sass, and JavaScript.
https://aleksandrhovhannisyan.com/
114 stars 26 forks source link

Add Comments to a Static Site with Netlify Functions and the GitHub API #117

Open AleksandrHovhannisyan opened 3 years ago

AustenLamacraft commented 2 years ago

Thanks for this great tutorial! I'm just beginning to work through it. One typo I just came across is that in Testing Netlify Functions Locally the flag should be --querystring not --queryString i.e. no camel case.

AleksandrHovhannisyan commented 2 years ago

@AustenLamacraft Thanks for letting me know! Fixed.

muratcorlu commented 2 years ago

Is there a reason not to use GitHub issues (first entry) also as the source of the article itself? I see some good benefits of doing that:

Some potential issues that I see:

I want to give it a try but wanted to mention here first to get early insights about this idea.

AleksandrHovhannisyan commented 2 years ago

@muratcorlu It's certainly an interesting idea. One reason I might not do this is because it ties you down to that one repo, whereas imo your articles should be independent media that you can transfer between different CMSes/source control platforms as needed. Another reason is that authoring posts in GitHub issues limits your ability to add custom styling, JavaScript, semantics, and other design elements. For example, you can't use shortcodes (e.g., 11ty) or MDX (Next/Gatsby).

If it works for you, though, go for it!

Ahart4u2 commented 2 years ago

Enjoyed the information in the article. Also the article on Twitter was so true. It will take over and you have to take a break from all social media.

Thank you

JeffML commented 2 years ago

One more typo:

const { data: rateLimitInfo } = await Octokit.rateLimit.get();

Should read: const { data: rateLimitInfo } = await octokitClient.rateLimit.get();

AleksandrHovhannisyan commented 2 years ago

Oops 😅 Thanks! @JeffML