AleksandrHovhannisyan
commented
1 year ago Hi again! In the future, it would really help if you could link to a minimal sandbox to reproduce the issue. This could be as simple as a bare-bones 11ty project (npm init, npm install @11ty/eleventy) with a minimal .eleventy.js config, a single source file (e.g., src/index.njk), and the plugin set up the way you want. I'll try my best to answer your questions without that, though:
In title required for accessibility Nunjucks variables do not work (but I can do without it, not so important)
Could you please share a small code sample for what you're trying to accomplish?
How can I place allowfullscreen into iframeAttributes? It gives me EleventyConfigError allowfullscreen is not defined (via ReferenceError)
You'll likely need to do allowfullscreen="true". Otherwise, Nunjucks will think you're trying to pass in a variable named allowfullscreen, which does not exist. I can clarify this better in the docs.
Entities (" < >) are displayed in the output (_site) instead of quotes, opening and closing tags. Maybe it does not matter as browsers read them anyway?
This is working as expected—those characters are being escaped as HTML entities so that they don't break the outer quotes in the HTML attribute. Are you seeing any issues where the code is not working as expected?
Or maybe this is the reason why output is not properly minified in some lines (see those starting with /assets/img/audio-player)?
This has more to do with how minify-html works. Since the code in question is inside an HTML attribute, that package has no way of knowing how to minify that particular string. For all it knows, the newline characters may very well be legitimate/valid newlines. Is this causing any issues with malformed output on the page itself?
rocc-o
This plugin is working vey well. But I do have some questions, though.
In title required for accessibility Nunjucks variables do not work (but I can do without it, not so important)
How can I place
allowfullscreeninto iframeAttributes? It gives me EleventyConfigErrorallowfullscreen is not defined (via ReferenceError). Also, how to putloading="lazy"?Entities (
"<>) are displayed in the output (_site) instead of quotes, opening and closing tags. Maybe it does not matter as browsers read them anyway?Why output is not properly minified in some lines (see those starting with /assets/img/audio-player)?
Inside img tag
class=fullheight=160loading=lazysrc=/assets/img/audio-player/landscape-680.jpgwidth=680have no quotes, or entities, at all. And this may be a problem as I need to serve a fallback jpeg image to browsers who need it, and size and lazy loading to all anyway. No quotes also on a href at the beginning:class=fullandhref=https://w.soundcloud.com/player