search

AleksandrRogov / DynamicsWebApi

DynamicsWebApi is a Microsoft Dataverse Web API helper library for JavaScript & TypeScript
MIT License
268 stars 58 forks source link

I feel like the intention here is to use `replaceAll` rather than `replace` #117

Closed m1c43L closed 2 years ago

m1c43L commented 2 years ago

https://github.com/AleksandrRogov/DynamicsWebApi/blob/2866b41da48d38ff33683b9b3eed3cff82977bab/lib/helpers/ErrorHelper.js#L145

This is cause a buggy behavior when we are doing something like key=${JSON.stringify(value)}. It would only replace one of the double quote to single quote causing the line below it to throw.

AleksandrRogov commented 2 years ago

@m1c43L true.

AleksandrRogov commented 2 years ago

going to replace it with a regular expression