AAD Impersonation - Githubissues

azakariaMSFT commented 4 years ago

Thank you for keeping this library awesome!

Fix impersonate documentation string where it is mixed with webApiUrl
Introduce an impersonateAAD option for the new preferred way for impersonating a user via an azure object id directly from the auth claims Preferred: Impersonate a user based on their Azure Active Directory (AAD) object id by passing that value along with the header CallerObjectId. docs: https://docs.microsoft.com/en-us/powerapps/developer/common-data-service/webapi/impersonate-another-user-web-api

mimicked over MSCRMCallerID which accepts a systemuserid Tested via a nodejs server (not included) that uses an application id to authenticate and takes the user aad object id directly from the passport authInfo

coveralls commented 4 years ago

Coverage increased (+0.03%) to 95.797% when pulling 7bbc78f20f8adccc4ec92574b996858c9326765d on azakariaMSFT:master into 3745154620aece8e323402b025c704861dcccaff on AleksandrRogov:master.

AleksandrRogov commented 4 years ago

@azakariaMSFT that's awesome! thanks for the PR. It would be even more awesome if you could add additional tests for the new functionality. If not, let me know I will add them later myself.

Thanks so much!

azakariaMSFT commented 4 years ago

absolutely, I'm working on those tests now.

AleksandrRogov commented 4 years ago

@azakariaMSFT awesome! thank you!

azakariaMSFT commented 4 years ago

Thanks, What is the cadence for releasing an update on npm?

AleksandrRogov commented 4 years ago

@azakariaMSFT I'll release it in the morning (September 8).

azakariaMSFT commented 4 years ago

Super, Thank you!

AleksandrRogov / DynamicsWebApi

AAD Impersonation #76