search

Alekseon / magento2-widget-forms

Place custom forms in your CMS content on your Magento 2 website
Other
36 stars 9 forks source link

Magento 2.4.4 #5

Closed sejas76 closed 2 years ago

sejas76 commented 2 years ago

Hello,

Just wondering if anyone has successfully run this module in the new Magento 2.4.4? I have installed it successfully (bin/magento module:enable Alekseon_AlekseonEav Alekseon_CustomFormsBuilder Alekseon_WidgetForms Alekseon_WidgetFormsReCaptcha) and set up the forms and widget in admin. however on load the only error message I get is on chrome console [ERROR] Failed to load the "Alekseon_WidgetForms/widget-form" template requested by "widgetForm-1". Any Ideas? Thanks Even

ticbitvax commented 2 years ago

The same thing happens to me, exactly the same error. Any solution? Thanks!

xavitriu commented 2 years ago

We are seeing the same problem. Any idea??

IJOL commented 2 years ago

Hi, I'm glad to see that I'm not alone :-o, we are experiencing the exact same issue... The form do not load in a cms page and the javascript console log in chrome spits the same mesage:[ERROR] Failed to load the "Alekseon_WidgetForms/widget-form" template requested by "widgetForm-1"

ticbitvax commented 2 years ago

We have been able to find the solution, or at least it has worked for us. In the "widget-form.html" file (vendor/alekseon/widget-forms/view/frontend/web/template/), change line 21 by closing the

**
**

@Funfelek @marcin-libelt @marcinfr @Linek If you could please update the file. Thank you!

Linek commented 2 years ago

Hi @sejas76 @ticbitvax @xavitriu @IJOL Thank you for your report.

We'll take care of this issue within next 5 days sprint, so please expect the update soon.

sejas76 commented 2 years ago

Excellent, I just applied the changes, I also closed off the span tag on line 17 and the fieldset on line 25 - not sure if this makes any difference but noted that Magento 2 also kicks errors when tags are not closed correctly (found this to be the case when the pagebuilder saves img files, it saves e.g<img src="xxx" width="50px /> instead of <img src="xxx" width="50px></ img>.

Just for anyone also finding issues with the newsletter settings giving errors like TypeError: Magento\Newsletter\Model\SubscriptionManager::subscribe(): Argument #1 ($email) must be of type string, array given, you need to ensure in Newsletter Settings "Email Field" drop down is selected for your field 'email address' or whatever you called your field containing the email address.

This is a great module, thank you for your support in maintaining this project.

marcin-libelt commented 2 years ago

Hello, issue has been fixed abd pushed to repo. Thank you @sejas76 @ticbitvax for your involvement.

It seems that the most top of html elements in knockout condition tag must be a regular tag with the ending tag. `

    <!--/ko-->`

This example would also work: `

    <!--/ko-->`