search

AlekseyAfonin / EquipBestItem

Mount & Blade: Bannerlord mod
https://www.nexusmods.com/mountandblade2bannerlord/mods/369/
MIT License
6 stars 3 forks source link

1.4.3 Beta Compatibility? #6

Closed shadowhen closed 2 years ago

shadowhen commented 4 years ago

TaleWorlds has released a 1.4.3 beta patch, and when I look at the mod's posts on NexusMods, people talk about a crashing issue. I found one issue with the code, which the MyInventoryLogic does not exist.

public MainViewModel()
{
    _inventoryLogic = InventoryManager.MyInventoryLogic;
    _inventory = InventoryBehavior.Inventory;
}

I replace MyInventoryLogic with InventoryLogic, which result the mod to build successfully and work properly for now.

public MainViewModel()
{
    _inventoryLogic = InventoryManager.InventoryLogic;
    _inventory = InventoryBehavior.Inventory;
}

I haven't checked if the code would work on the stable patch 1.4.2., but TaleWorlds has refactored and cleaned up its code according to patch notes for beta.

shadowhen commented 4 years ago

I also fixed the mod by uploading one to NexusMod. I can remove or hide it if you want me to. Here is the changed file in question for fixing.

AlekseyAfonin commented 4 years ago

Hello, Henry. Thanks for the fix. I don't have time to do the mod yet, so let it be up to you.