search

AlekseyKorzun / reCaptcha-PHP-5

Proper PHP 5 client for reCaptcha client
http://www.google.com/recaptcha/intro/index.html
Other
40 stars 26 forks source link

PSR-2 Compliance #5

Closed pmjones closed 11 years ago

pmjones commented 11 years ago

You state the project has "100% PSR-2 code coverage". However, PSR-2 states that one must use a 4-space indent, not a tab, and it looks like at least some of the codebase uses tabs. There's nothing wrong with tabs, but to truthfully advertise full compliance means it'll have to be 4-space indents.

AlekseyKorzun commented 11 years ago

Internet is serious business. What code are you talking about in particular? There has been two commits by contributors that might have slipped in tabs.

Thanks.

pmjones commented 11 years ago

Sure thing man :-) Yeah it's tough to keep tabs (ha!) on your contributors.

For example, this whole file looks tabbed to me: https://github.com/AlekseyKorzun/recaptcha-php-5/blob/master/Package/Captcha/Captcha.php

AlekseyKorzun commented 11 years ago

You are correct, new editor install updated everything to tabs :-1:

Commited a fix: https://github.com/AlekseyKorzun/recaptcha-php-5/commit/d38d678edec690d44f47baaaaac6f61f398994e2

Thanks!

pmjones commented 11 years ago

Very welcome, and thank you for your attention to detail. :-)