fix file_content path - Githubissues

Aleksi44 / wagtailsvg

Wagtail + SVG

https://pypi.org/project/wagtailsvg/

GNU General Public License v3.0

35 stars 24 forks source link

Closed ekersten closed 3 years ago

ekersten commented 3 years ago

file_content was trying to fetch the wrong file path. This fixes that.

ekersten commented 3 years ago

I've also changed the upload path to svg to make it cleaner.

Printing the file_content on a template still requires the safe filter but I find that acceptable

Aleksi44 commented 3 years ago

Hi @ekersten

Thanks for this pull request.

Some comments :

I think the upload_to value should be filled in from Django's settings.py. Something like SVG_FOLDER_UPLOAD_TO = 'svg' (with 'media' as default value if it's not set)
Change of upload_to break updates. If someone wanted to update this package (mix between files/folders)

What do you think?

ekersten commented 3 years ago

Sounds reasonable.

I've created a setting called WAGTAILSVG_UPLOAD_FOLDER and it defaults to media

Aleksi44 commented 3 years ago

Merged here :

wagtailsvg==0.0.19

I updated the README and cleaned up the code a bit.

Thanks @ekersten