Aleksoid1978 / MPC-BE

MPC-BE – универсальный проигрыватель аудио и видеофайлов для операционной системы Windows.
GNU General Public License v3.0
2.17k stars 88 forks source link

Add recognition of webm-audio files #427

Closed mlatushko closed 5 months ago

mlatushko commented 5 months ago

2024-04-06_195027

Load external audio tracks default list: Audio files (all types) >> webm

v0lt commented 5 months ago

No. Because .WEBM is most often a video file.

mlatushko commented 5 months ago

For users who download from YT, this is often an audio format. It will be additionally convenient if you add the extension to the list of extensions, since it is - albeit infrequently for some - also an audio format.

// Для пользователей, которые скачивают с YT, это чаще аудиоформат. Будет дополнительно удобно, если вы добавите расширение в список-перечисление расширений, так как это - пусть для кого-то нечасто, - также и аудиоформат.

v0lt commented 5 months ago

We will not redefine ".webm" as an audio file, because this will break the logic of some player functions.

It would probably be possible to create an additional group for ".webm" in the audio file opening dialog. But this will be strange and inconvenient, because there is already a group "All files" for such cases.

Adding ".webm" to the "Audio file (all types)" group only in the audio file open dialog might seem like a good solution. But it will cause confusion among users when they see video files in the audio file opening dialog.

I suggest you rename your ".webm" audio files to ".mka".

mlatushko commented 5 months ago

Understand. My download line is such that video and audio with this extension differ in prefix, for example: 243/244/247 for video, 249/250 for audio, and most often I download libraries. If the names are similar, but the distinguishing postfix part is hidden after the long name, then video from audio is determined only by size.

In this dialog box, after all, there is a request for an audio format, not video. Since file types are different for the same extension designation, it is up to users to organize their files. It seems to me that the most common use case for the load tracks function is to find an audio file located next to the currently playing video. It will save more time if the "webm" extension is included in the enumeration list in this dialog box.

›› rename your '.webm' audio files to '.mka' – It's easier to extract from XRecode|gMKVExtractGUI than to pack into .mka

Y --write-description --no-keep-fragments --no-part --no-playlist -c -w -i -k --console-title --no-warnings --no-check-certificate --flat-playlist --youtube-skip-dash-manifest --max-filesize 960M -o "D:\(Downloads)\%(uploader)s\%(format_id)s %(title)s [YTv %(id)s %(upload_date)s] %(uploader)s.%(ext)s" -f 251/250/249/251-dash/250-dash/249-dash/140/139/600/599 -a "S:\SHORTS.txt" & :: --write-thumbnail --write-subs --write-auto-subs --sub-lang ru --get-comments --skip-download