Aleksoid1978 / MPC-BE

MPC-BE – универсальный проигрыватель аудио и видеофайлов для операционной системы Windows.
GNU General Public License v3.0
1.88k stars 83 forks source link

buffer length with internal filter/splitter #500

Closed craigyhay closed 2 weeks ago

craigyhay commented 2 weeks ago

request for consideration.... At present mpc-be will only allow a maximum of 15 seconds of buffer length with internal filter/splitter, which for using mpc-be with a streaming internet source can be quite short and cause issues on a less than perfect connection or several second freezes when fast forwading.

As memory these days is relatively cheap and plentifull, could the limit of 15 seconds please be lifted? Obviously the default buffer length could be left where it is, but the option of a longer buffer for some can be very beneficial with the only very minor downside of a small wait when playback starts, which is far better than the playback potentially ending mid-way through video forcing to start playback again from start and have to find place to resume playback from.

v0lt commented 2 weeks ago

I didn't understand well what real problem you want to solve. But let me remind you once again that a buffer is not a cache.

craigyhay commented 2 weeks ago

The problem I would like to solve is that when there is a minor internet connection loss there is enough buffer so that playback isnt paused and fails but instead hopefully the buffer would be larger to cover this period of loss of internet conectivity.

At present what seems to happen during a momentary internet loss is that the buffer runs out and the player then stops,when internet connection is regained player remains in a paused state and dosent try or allow for the playback the remainder of the video.

I also would like to solve the problem of fast forwading longer than 15 seconds dosent cause pauses for the data to be retrieved/buffered.

Aleksoid1978 commented 2 weeks ago

No - it doesn't work the way you think. 1) If the connection is lost, no matter how much buffering there is, playback will still stop. 2) The internal buffer has nothing to do with rewinding. When rewinding, the buffer is reset. If you want to watch online consistently - either choose a fast source, or download and watch offline.