search

Aleksoid1978 / MPC-BE

MPC-BE – универсальный проигрыватель аудио и видеофайлов для операционной системы Windows.
GNU General Public License v3.0
2.11k stars 86 forks source link

PGS Subtitles not rendering properly on Cropped Video #547

Closed FlaTechNole21 closed 3 weeks ago

FlaTechNole21 commented 3 weeks ago

In the 1.7.3 release, PGS subtitles no longer render properly in cropped video. For example, I have a 1920x800 cropped video with 1920x1080p resolution PGS subs. In version 1.7.2 they render in the same location as the original 1920x1080 video, but now they're located higher up to fit in the 1920x800 window.

v0lt commented 3 weeks ago

For example, I have a 1920x800 cropped video with 1920x1080p resolution PGS subs. In version 1.7.2 they render in the same location as the original 1920x1080 video

If you cut the video from the top, the subtitles will not be in their original position.

but now they're located higher up to fit in the 1920x800 window.

Yes. Because otherwise you will not see them at all. See https://github.com/Aleksoid1978/MPC-BE/issues/515.

clsid2 commented 3 weeks ago

And solution is simple: watch in fullscreen

FlaTechNole21 commented 3 weeks ago

I am watching in Fullscreen, that's the problem. It's only rendering within the video window in Fullscreen mode, but some of the subtitles should be in the black space.

v0lt commented 3 weeks ago

I am watching in Fullscreen, that's the problem. It's only rendering within the video window in Fullscreen mode, but some of the subtitles should be in the black space.

Show a screenshot with an example when subtitles should be in a black space.

FlaTechNole21 commented 3 weeks ago

So, I found something interesting grabbing these screenshots.

v1.7.2 Screenshot taken via the Player: PGS_Sub_1 7 2

v1.7.3 Screenshot taken via the Player: PGS_Sub_1 7 3

v1.7.3 Screenshot taken via Print Screen (what I actually see): PGS_Sub_1 7 3_actual

FlaTechNole21 commented 3 weeks ago

I should also note my LAV Splitter subtitle settings: LAV_Splitter_Settings

v0lt commented 3 weeks ago

I didn't see in the screenshots a reason why the subtitles had to be below the video frame.

Check in MPC-BE 1.7.3.15.

FlaTechNole21 commented 3 weeks ago

I confirmed that v1.7.3.15 fixes this issue.

As for a reason, a lot of movies design their subtitles to be there. That's also where I prefer most subtitles for 2.39/2.40 aspect ratio movies, with the exception of 3-line and/or placement specific subs.

Thanks!

v0lt commented 3 weeks ago

Improved in commit 12448a9.