Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.06k stars 119 forks source link

HDR video go full black screen on video start and end #102

Closed molitar closed 11 months ago

molitar commented 11 months ago

How do I stop this annoying behavior no matter what video I play my entire monitor goes to full black than starts playing video and when I stop it does the same thing.

Aleksoid1978 commented 11 months ago

It is completely unclear what is happening. Maybe your player switches the screen frequency, maybe something else. Or Fullscreen is selected in the renderer, and when entering/exiting the full screen, reinitialization occurs.

clsid2 commented 11 months ago

Auto Display HDR on/off setting?

Or if HDMI connection: NVIDIA driver > Display > Adjust color settings > "content type reported to display" = Desktop Programs

molitar commented 11 months ago

It appears to be more of cutting display to monitor when it starts and stops rendering. The entire goes pure black as if PC went to sleep or that. My GPU is an AMD Radeon 5600XT

v0lt commented 11 months ago

It appears to be more of cutting display to monitor when it starts and stops rendering. The entire goes pure black as if PC went to sleep or that. My GPU is an AMD Radeon 5600XT

I think this is a driver bug.

clsid2 commented 11 months ago

Auto Display HDR on/off setting! Disable that as see what happens.

molitar commented 11 months ago

Auto Display HDR on/off setting! Disable that as see what happens.

Thanks you solved it! That was the problem!

clsid2 commented 11 months ago

More and more people have HDR mode enabled by default in Windows.

At default settings MPCVR will turn HDR off whenever a user plays a SDR video. My opinion is that it should never turn off HDR in Windows. It should only turn on HDR when needed (and then off again at end of playback).

I have a patch for it if you want to change the behavior.

molitar commented 11 months ago

More and more people have HDR mode enabled by default in Windows.

At default settings MPCVR will turn HDR off whenever a user plays a SDR video. My opinion is that it should never turn off HDR in Windows. It should only turn on HDR when needed (and then off again at end of playback).

I have a patch for it if you want to change the behavior.

Sounds great

Aleksoid1978 commented 11 months ago

Yeah - and then there will be questions when playing SDR video, why it looks somehow strange (the HDR mode was just turned on in the system).

clsid2 commented 11 months ago

Are you assuming that or have you actually tested it? I have not heard any complaints.

Aleksoid1978 commented 11 months ago

SDR look's not "good" when HDR mode enabled

clsid2 commented 11 months ago

Yet, there are many people who prefer that. Why not just give an option to do "HDR on" only in addition to current "HDR on/off"?

Aleksoid1978 commented 11 months ago

Why not just give an option to do "HDR on"

Patch are welcome.

clsid2 commented 10 months ago

Patch is on my ToDo list.