Mouse cursor does not always disappear

Aleksoid1978 / VideoRenderer

Внешний видео-рендерер

GNU General Public License v3.0

1.06k stars 119 forks source link

Mouse cursor does not always disappear #117

Closed roberto-sartori-gl closed 8 months ago

roberto-sartori-gl commented 8 months ago

Hi!

Issue: in certain conditions, using more than one display, the mouse cursor does not disappear over the video.

Steps to replicate:

Enable 'Reinitialize D3D device when changing display'
Open a video on the primary display and wait for it to start playing
Move the MPC window from the primary display to a secondary display
Put the video full screen on the secondary display
From this moment, the mouse cursor will not disappear over the video anymore, even if the video is not full screen. The only way to restore the 'stock behaviour' is to restart MPC.

The issue does not appear:

With the 'Reinitialize D3D device when changing display' option disabled
Not using MPC VideoRenderer.

Aleksoid1978 commented 8 months ago

I can't check it - don't have secondary display.

clsid2 commented 8 months ago

Normally CMouse::InternalOnMouseLeave() gets called when mouse exits the video area. That stops the pointer hider. After the device gets reinitialized, behavior becomes weird. Now it suddenly MouseLeave gets called when hovering the video area.

EVR-CP works ok after device reinitialize.

Aleksoid1978 commented 8 months ago

Although - what does MPC VideoRenderer have to do with it, everything related to the mouse is controlled in the player. Have you checked in MPC-BE?

clsid2 commented 8 months ago

I am just sharing my findings. There is no renderer specific code for the mouse handling. So I am not sure what is wrong.

Aleksoid1978 commented 8 months ago

Although - what does MPC VideoRenderer have to do with it, everything related to the mouse is controlled in the player. Have you checked in MPC-BE?

If there is no answer, I will close the issue.

clsid2 commented 8 months ago

Does not seem to happen in BE fullscreen. Did notice BE never hides pointer in windowed, even without reinit.

@adipose Do you perhaps have any idea what might be wrong?

adipose commented 8 months ago

Does not seem to happen in BE fullscreen. Did notice BE never hides pointer in windowed, even without reinit.

@adipose Do you perhaps have any idea what might be wrong?

Guess is the mouse leave code is losing the parent window or something. I can test later to see if I can repro it.

Aleksoid1978 commented 8 months ago

This does not apply to the renderer.