Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

Fixing SuperResolution implementation, adding RTX Video HDR, and other small fixes #127

Closed JTGaming closed 5 months ago

JTGaming commented 5 months ago

Fixed SuperResolution so it now behaves more nicely on HDR screens, is only enabled when it is supported, and the debug screen more closely shows when it is actually active. Added support for RTX Video HDR for videos that can use this feature. There's also a UI button for it, and it shows up on the debug screen when it's in use. Fixed an issue where dragging an HDR window from an SDR screen to an HDR screen before the video has initialized would default the window to SDR mode. Fixed an issue where toggling from fullscreen to windowed mode on a multi-monitor setup would make the renderer think we swapped monitors. Turning off HDR passthrough in UI now resets the window to SDR. Realigned some options in the UI.

I've tried to keep every commit commented so it should be easy to see what each change is doing.

Aleksoid1978 commented 5 months ago

I repeat, I don’t know how many times - until the developers have the appropriate video cards with support for SuperRes / Nvidia RTV Video HDR - there will be no changes in the code.

Well, even more so such requests in which everything is in a heap - here there are SuperRes and Nvidia RTV Video HDR and some changes in the UI.

Aleksoid1978 commented 5 months ago

Let this request remain open for now - for the future.

v0lt commented 5 months ago

Thanks for the detailed pull request. We will analyze the patches and accept some of the changes, but not quickly.

I don’t know how to accept individual commits here, so I will make changes myself with attribution.

clsid2 commented 5 months ago

Here is another implementation that you can use for comparison: https://github.com/emoose/VideoRenderer/commits/rtx-hdr/

Aleksoid1978 commented 5 months ago

Can you make a separate pull request just for RTX HDR ?

Aleksoid1978 commented 5 months ago

I made my own implementation of this functionality.