Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

HDR-to-SDR conversion doesn't work with DmitriRender [DmitriRender bug] #135

Closed Toff-kun closed 3 months ago

Toff-kun commented 3 months ago

Enabling DmitriRender makes MPCVR's HDR-to-SDR conversion stop working for some reason.

DmitriRender disabled:

DmitriRender disabled

DmitriRender enabled:

DmitriRender enabled

Is it possible to make it compatible somehow? MadVR doesn't have this issue, so I assume it is MPCVR-related.

v0lt commented 3 months ago

Your DmitriRender corrupts the properties of the video frame. See Matrix, Primaries, Functions.

Is it possible to make it compatible somehow?

Contact DmitriRender support.

Toff-kun commented 3 months ago

Why doesn't it break HDR-to-SDR on MadVR then?

v0lt commented 3 months ago

Why doesn't it break HDR-to-SDR on MadVR then?

I don't know. Perhaps madVR is doing something to bypass DmitriRender's incorrect behavior. But this is a wrong position that encourages others to do wrong things. We won't do that.

Toff-kun commented 3 months ago

Forgive me if my question sounds ignorant, but could it be that MPCVR simply doesn't have any profile for the "D3D11_P010" input format and defaults to the generic SDR processing as a result? Maybe all that's needed is to apply the same profile / processing to D3D11_P010 as to the regular P010?

v0lt commented 3 months ago

Forgive me if my question sounds ignorant, but could it be that MPCVR simply doesn't have any profile for the "D3D11_P010" input format and defaults to the generic SDR processing as a result?

You are not right. Open HEVC 10-bit with hardware decoding D3D11 (native) and you will see D3D11_P010.