search

Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.1k stars 122 forks source link

There is no option to enable Super Resolution for all video resolutions in 0.7.3.2210 #144

Closed neverabyss closed 7 months ago

neverabyss commented 7 months ago

Version 0.7.3.2210 only allows super resolution for video ≤FullHD, but Nvdia VSR supports at least QHD to QHD and QHD to UHD. This works for QHD video in 0.7.1.2172 but does't work in 0.7.3.2210 due to the lack of an option to enable Super Resolution for all video resolutions or a least for ≤QHD.

v0lt commented 7 months ago

Have you seen the positive effects of upscaling 1440p to 2160p yourself?

NBruderman commented 7 months ago

Have you seen the positive effects of upscaling 1440p to 2160p yourself?

I mean, if Nvidia supports it, why not leaving the decision to the user whether to use it or not?

v0lt commented 7 months ago

Firstly, you can’t believe everything on the Internet (there have already been precedents). And we won’t make a feature that doesn’t work, because the next “Issue” will be “the new feature doesn’t work.” Secondly, this makes no sense. I doubt there will be any improvement when upping 1440p to 2160p.

neverabyss commented 7 months ago

Have you seen the positive effects of upscaling 1440p to 2160p yourself?

Yes, I see a positive effect from this scaling, it suppresses compression artifacts and the edges become smoother and clearer. Here are some examples:

2560x1440 -> 3840x2160

frame1

2560x1440 -> 3840x2160 + Super Resolution

frame1+vsr

2560x1080 (QHD width) -> 3840x1620

frame2

2560x1080 (QHD width) -> 3840x1620 + Super Resolution

frame2+vsr
clsid2 commented 7 months ago

It supports up to 1440p as per official NVIDIA FAQ. That was 1080p in older drivers.

v0lt commented 7 months ago

Super Resolution support for 1440p has been added in commit a9fadf9.

neverabyss commented 7 months ago

Super Resolution support for 1440p has been added in commit a9fadf9.

Thank you.