Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

rtx super resolution causes washed out video #146

Closed RichardLuo0 closed 2 months ago

RichardLuo0 commented 2 months ago

It looks like a grayscale filter. sry I can't take screenshot because once I pause the video or move mouse to the slider, the filter like effect is gone. The only solution is to turn off rtx vsr in settings.

Some info you may be interested: image

v0lt commented 2 months ago

Check it out in the Chrome browser.

RichardLuo0 commented 2 months ago

Check it out in the Chrome browser.

In Chrome browser, it looks perfect, no washed out or anything. If I check the nvidia panel, the super resolution and rtx hdr is working. And it seems its not only vsr. If I enable rtx hdr only, the same problem occurs. But if I have both of them disabled or disable all options under "use for", the problem is gone.

I finally got a picture of the problem: image washed out image normal

RichardLuo0 commented 2 months ago

Check it out in the Chrome browser.

I think I figured it out. It was nvidia app. I shouldn't turn on rtx hdr there. It seems that option will do a second processing which conflicts with the renderer.

RichardLuo0 commented 2 months ago

hi, it happens again. As long as I set the window to maximum or fullscreen, the washed-out effect will appear. And now it doesn't matter if I pause the video or move mouse to the slider, it is just there.

image

image

If I play in chrome as mp4 format, its looks fine.

Aleksoid1978 commented 2 months ago

1 - On your screen - HDR Passthrough is not working. 2 - You use old version MPC VR.

RichardLuo0 commented 2 months ago
  1. ok but why its not working? It worked before (see my first screenshot, btw its a different video)
  2. What do you mean by its old version? The latest release on GitHub is 0.7.3.2210

And none of them answers my question: why is there a washed-out effect with vsr?

Aleksoid1978 commented 2 months ago

https://github.com/qwerttvv/Player/releases

Aleksoid1978 commented 2 months ago

Washed-out - because it's convert to hdr but not pass through to display. But - i can't reproduce, for me all working.

RichardLuo0 commented 2 months ago

https://github.com/qwerttvv/Player/releases

Should I use nightly builds?

RichardLuo0 commented 2 months ago

Washed-out - because it's convert to hdr but not pass through to display. But - i can't reproduce, for me all working.

I don't think it's related to hdr. Even if I turn off the RTX hdr, still same problem. It is fine if I make the mpc window smaller than the video, but the problem appears once it exceeds the size of the video.

RichardLuo0 commented 2 months ago

https://github.com/qwerttvv/Player/releases

Change the mpc-be version doesn't matter

RichardLuo0 commented 2 months ago

I tried some other videos and it works fine, which is wired, Can you try https://thepiratebay.org/description.php?id=36632388 S03E01?

Aleksoid1978 commented 2 months ago

As i see - it's working. изображение

RichardLuo0 commented 2 months ago

It seems the issue has been fixed in 0.8. You should release it as soon as possible (Your latest release on github is 0.7.3.2210 in case you forget). Btw, I am using a monitor with 0-255, do I need to enable 16-255 to 0-255 shader for this movie? But this shader makes the movie look way too dark.

v0lt commented 2 months ago

You should release it as soon as possible

https://github.com/Aleksoid1978/VideoRenderer/wiki/Nightly-builds use the builds from the link

RichardLuo0 commented 1 month ago

I am sorry to reopen this, but it seems though the moive overall is not washed out, now its some part of it is. In short if i move my mouse over slider or any ui elements is over video, then part of the video gets washed out (mostly light sources).

RichardLuo0 commented 1 month ago

Or is it actually the other way around? Maybe the kinda washed-out looking is the correct one? I don't have much experience with hdr before, so what exactly should hdr be like?

clsid2 commented 1 month ago

You can use Alt+PrintScr to send screenshot to clipboard and then later paste that into Paint.

RichardLuo0 commented 1 month ago

With Windows Snipping Tool and any other screenshot tool, the screenshot looks oversaturated. With Xbox game bar, they look identical whether washed out or not. After some digging, I found this: https://codecs.forumotion.net/t3979-hdr-not-rendered-correctly-at-fullscreen

Windowed mode - Normally when you toggle to full screen mode, you are seeing an incorrect map of luminance values from your source HDR material (with different peak values between source and destination device), which is manifesting as "washed out" in full screen mode - In windowed mode, Windows 10 is doing an approximate map of the peak nits values, aligned to your HDR device's peak nit value. However, in the case of an HDR1000 mastered movie (or higher) mapped to an HDR400 monitor, you'll notice the "bright" areas of the video are almost too bright, and it is clipping at the upper end of the luminance range. - In full screen mode, madVR is passing the HDR info directly to your screen, including the meta data, without tone mapping of the luminance. In this example, HDR1000 content going to a HDR400 monitor, it causes it to look washed out, and not have proper peak luminance values. - By using "tone map HDR using pixel shaders", you are fixing the issue in windowed and full screen mode by properly mapping the HDR1000 content luminance values to a narrower HDR400 luminance range (but still aligning peak values properly). Changing between "windowed full screen" vs "full screen" will now yield the correct result.

Assuming he is correct, is there a similar thing as "tone map HDR using pixel shaders" in mpc-vr?

clsid2 commented 1 month ago

That is for tonemapping HDR to SDR.

RTX HDR is for doing the exact opposite.

Maybe this will help with the colors in "windowed" case: https://support.microsoft.com/en-us/windows/calibrate-your-hdr-display-using-the-windows-hdr-calibration-app-f30f4809-3369-43e4-9b02-9eabebd23f19

Also look in the NVIDIA app for the status of RTX HDR and SuperResolution. If RTX HDR gets (temporarily) deactivated, then that can explain why colors are changing.

RichardLuo0 commented 1 month ago

I think he means tone map HDR 1000 content to HDR 400 monitor, not HDR to SDR. And I forgot to mention that this also happens to native HDR videos.

RichardLuo0 commented 1 month ago

I downloaded mad VR. If I choose passing through in mad VR, with a native HDR video, it has the same problem as mpc VR (except in mad VR colors become bright when resizing, and washed out a little at any other times). If I choose "tone map HDR using pixel shaders" with peak brightness 400, it is even more washed out! Though the color doesn't change anymore.

RichardLuo0 commented 1 month ago

Basically mpc vr pass-through looks identical to madVR pass-through. And "tone map HDR using pixel shaders" is actually more washed out. I guess it is because of monitor has its own tone mapping and pass-through leaves the work to the monitor (If not, then oversaturated).

RichardLuo0 commented 1 month ago

But there is one thing that mad VR does better. It will keep passing through no matter what is over the video. However, in mpc vr simply pausing the video will cause color changing