Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

Unexpected channel shifting #158

Closed atrukhin closed 1 month ago

atrukhin commented 1 month ago

Hi devs, seeing the following issue with some movies

Sample: https://disk.yandex.ru/i/jtBikjNjLEG27w

It looks fine with web player image

But in mpc-be with mpcvr it looks like some channel(s) are shifted (with vertical flip?) resulting in corrupted colors at the top image

Using all latest mpc-be 1.7.1 and mpc-vr 0.8.1.2230 with SW decoding

Settings are: image

image

Aleksoid1978 commented 1 month ago

All is good for me. изображение

Aleksoid1978 commented 1 month ago

Input format is different, it's strange. Must be as on my screenshot.

clsid2 commented 1 month ago

LAV Video shows 464x348 as input as well, but without DAR behind it. Playback is ok.

So he is using other decoder or maybe just old version.

v0lt commented 1 month ago

Try turning off Request Super Resolution. Try turning off RXT Video HDR. Try turning off NV12.

atrukhin commented 1 month ago

after digging more into this issue it turns out to be MPC video decoder issue not renderer:

image

image

so if you still want to investigate/fix it i can reopen it in respective repo

v0lt commented 1 month ago

I didn't write anything about video decoder settings. We are discussing MPC Video Renderer. Right? mpcvr_options

atrukhin commented 1 month ago

unfortunately tweaking renderer settings do not help i only could resolve it by disabling NV12/YV12 in decoder settings

image

v0lt commented 1 month ago

The difference is in the "Input Format" line. No frame cropping to 464x348. The external filter may be interfering.

Here is the list of my external filters (Play > Filters > Copy filter list to clipboard):

MPC-BE x64 1.7.1.2 dev
Filters currently loaded:
  - MPC Audio Renderer
  - MPC Video Renderer
  - Audio Switcher
  - MPC Video Decoder
  - MPC Audio Decoder
  - MPC FLV Source
atrukhin commented 1 month ago

mine are:

MPC-BE x64 1.7.1 Filters currently loaded:

I disabled VapourSynth Filter and it helped without any other settings tuned (enabled back everything disabled before in rendered/decoder)

image

so if it looks like VapourSynth Filter issue and nothing to investigate/fix in mpc decoder/renderer please close this one

and i will submit it to their repo

v0lt commented 1 month ago

MPC FLV Source reports that the frame is 464x352, which needs to be cropped to 464x348. Your VapourSynth Filter loses its cropping information and ends up with a color band.

LAV Splitter Source immediately reports that the frame is 464x348. Why there is such a difference in source filters is still unclear to me.

atrukhin commented 1 month ago

i replaced MPC FLV Source with LAV Splitter source and it also helps - i could keep VapourSynth enabled and no banding seen

image