Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

Color correction doesn't work #162

Closed bibsp closed 1 month ago

bibsp commented 1 month ago

Color correction settings in MPCBE/HC doesn't work with AMD GPU, when using MPCVR and the video is 10bit. EVRCP fine with 10bit video. MPCVR fine with only 8bit video. AMD Ryzen 5 5600H.

Aleksoid1978 commented 1 month ago

EVR CP - DX9, MPC VR - I think DX11, possible drivers fault.

Aleksoid1978 commented 1 month ago

Nvidia - all working, 8/10 bit.

v0lt commented 1 month ago

Disable DXVA2/D3D11 video processor for P010.

bibsp commented 1 month ago

Disabling DX11 in renderer or disabling P010 works. Screenshot (286) Screenshot (287) In both these cases color correction works.

v0lt commented 1 month ago

Added information to Known Issues.

clsid2 commented 1 month ago

@v0lt Perhaps include additional sentence for each issue like: "May happen with for example X/Y/Z, and possibly other GPU models."

It is useful for both devs and users to know which models suffer from the problem. Certainly if it affects only older models, and you consider upgrading to new GPU from same vendor.

I may also look into implementing a future patch to "optimize" the default settings when resetting (and on initial use). Then it is important to know which GPUs need workarounds.

v0lt commented 1 month ago

@clsid2 I don't have that information. I know that some AMD graphics adapters may have limitations when running P010. Some problems have been fixed in new versions of the driver. But I did not collect detailed information and we do not plan to add a list of adapters (and especially drivers) to the MPC VR code.