Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

Super Resolution on vertical video with >= 1440p Frame Height #165

Closed jameswortiz728 closed 4 weeks ago

jameswortiz728 commented 1 month ago

Super resolution does not seem to scale vertical videos with >= 1440p frame height, ex. 1080x1920 will not be upscaled. It works as intended with vertical and horizontal video <= 1440p with the right settings.

I use a 4k monitor in portrait mode for vertical content that I would also like to have upscaled as the 1080p looks a bit blurry. I believe this is a new issue as it has worked in the past, unless there is a setting I am missing. Thanks.

v0lt commented 1 month ago

The request is clear. There was even a patch for something like this somewhere. But it’s unclear why use Super Resolution when the frame height is slightly smaller than the display height?

jameswortiz728 commented 4 weeks ago

In the example I mentioned its more similar to upscaling from 1080p to 4k res, but in a vertical format. Upscaling video from 1920x1080 to 3840x2160 (Horizontal) works as it should, but scaling from 1080x1920 to 2160x3840 (Vertical) does not trigger super resolution. In both cases, super resolution would add similar fidelity, but it only triggers in the horizontal resolution.

Aleksoid1978 commented 4 weeks ago

Can you upload video 1080x1920.

jameswortiz728 commented 4 weeks ago

Sure, the video is cut down to a 4 seconds clip to fit within githubs 10mb file size limit.

https://github.com/Aleksoid1978/VideoRenderer/assets/74321208/98a8fb13-de21-43eb-a2e5-6259b28e2c6a

v0lt commented 4 weeks ago

I think the solution should be like this. RotatedSuperRes.diff.txt

A little modification may be needed, which will become clear after testing.

Aleksoid1978 commented 4 weeks ago

Done.

v0lt commented 3 weeks ago

another solution with 1280p and 1920p https://disk.yandex.ru/d/diD-2ngj76vl-w

jameswortiz728 commented 3 weeks ago

Coming back to add that the above solution from v0lt is working! Super Resolution shows as Active when I test, and the fidelity increase is noticeable as well. Thanks a lot!!!