Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
983 stars 108 forks source link

[Feature request] chroma upscaling algorithm jinc to mpcvr Chroma upsampling #169

Closed AhmedSamir899 closed 1 week ago

AhmedSamir899 commented 1 week ago

i use mpc with madvr and notice that colors look much better with jinc compare to mpcvr with catmull-rom or bilinear chroma upsampling

v0lt commented 1 week ago

I can't agree with "colors look much better". On a regular video, people will not be able to feel the difference between Catmull-Rom and Jinc2m for chroma in a blind test. You'll likely see an improvement on special samples, but those are the rare cases you'll want to use madVR for. There are a lot of things in madVR that won't be implemented in MPC VR for various reasons.

AhmedSamir899 commented 1 week ago

"There are a lot of things in madVR that won't be implemented in MPC VR for various reasons." can you tell me the reason because even if there is no big difference between Catmull-Rom and Jinc2m it will not be bad to have both and you can choose.

Aleksoid1978 commented 1 week ago

Not planned.

v0lt commented 1 week ago

even if there is no big difference between Catmull-Rom and Jinc2m it will not be bad to have both and you can choose.

Catmull-Rom is simply implemented to increase the component by 2 times. Therefore, now we are implementing it as part of a large shader of color transformation. Jinc2m requires more input pixels and it has more complicated code. And since the benefits of it are not enough, we do not plan to introduce it.

AhmedSamir899 commented 4 days ago

what about Lanczos it gives almost same result as Jinc2m and more efficient

v0lt commented 4 days ago

Lanczos it gives almost same result as Jinc2m

No. It's similar to Catmull-Rom, but a little sharper. And as I said, on regular videos this does not make a noticeable positive difference in a blind test.