Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.1k stars 122 forks source link

DV works less than a second when in fullscreen, but works in windowed mode #177

Closed fcueto closed 3 months ago

fcueto commented 3 months ago

When I play DV content using mpc-hc 2.3.4 it is working and improves image quality considerably, but... it stops working in full-screen mode unless the seekbar is showing.

my settings: settings

Capture of the screen. DV works for less than a second then it disable (when in fullscreen)

fullscreen2

In windowed mode DV works normally

notfullscreen
fcueto commented 3 months ago

In case you want to know, "Prefer DV over PQ and HLG" makes no difference.

v0lt commented 3 months ago

I don't see any difference in color or statistics

fcueto commented 3 months ago

me neither but I don't know if what I capture is what I see on the screen?

clsid2 commented 3 months ago

See if this tool has any effect on colors in Windowed mode: https://support.microsoft.com/en-us/windows/calibrate-your-hdr-display-using-the-windows-hdr-calibration-app-f30f4809-3369-43e4-9b02-9eabebd23f19

v0lt commented 3 months ago

Try looking at DolbyVision Profile 5 samples. It will immediately be clear whether DolbyVision processing works or not. https://www.demolandia.net/4k-video-test/dolby-vision/page-1.html

clsid2 commented 3 months ago

The problem is probably related to which HDR metadata is used. Either the renderer's values or the default ones from Windows. I suspect fullscreen might be the "correct" ones from renderer, and in windowed mode it uses the default desktop values.

By using the calibration app he can test if that is the case.

fcueto commented 3 months ago

Colors are great on Profile 5 samples

Windows calibration tool has no effect. I tried with extreme values just to be sure but not effect at all.

When in windowed mode, DV seems to remain active. When in fullscreen mode, it works during a fraction of a second then DV goes off (my monitor removes the DV label right away) If I use the arrow keys to get back or forward, it activates DV again during .2 second and it goes off again.

my monitor is asus pg32ucdm with firmware 105

clsid2 commented 3 months ago

The renderer does not support DV passthrough, so the DV label that your monitor shows temporarily is nonsense.

The renderer converts DV into HDR10 and then does HDR passthrough.

fcueto commented 3 months ago

what you said about HDR metadata seems to be correct but I don't get why I see no difference playing with the HDR calibration tool. Maybe when windows 11 detects a DV capable display, it uses different metadata than the HDR calibrated ones ?

clsid2 commented 3 months ago

HDR calibration tool is for how the desktop looks in HDR mode.

It does not affect the metadata extracted from the video send out by the renderer. (when things are working as they should)

fcueto commented 3 months ago

I get that but does it affect how the desktop looks in DV mode ? (because when HDR is activated, windows 11 is sending a DV signal, and not HDR, when a compatible display is detected).

Aleksoid1978 commented 3 months ago

You can't output DV passthrough on Windows, only HDR. MPC-VR read DV rpu and convert DV colors to PQ. That's all.