Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.04k stars 116 forks source link

HDR image looks too dark #20

Closed z826540272 closed 3 years ago

z826540272 commented 3 years ago

HDR image looks too dark with HDR Screen

Aleksoid1978 commented 3 years ago

Can't confirm. Enable statistics and take screen, also take screen options.

z826540272 commented 3 years ago

i will test later

cdytoby commented 3 years ago

Hello, I can say that with D3D11, HDR works perfectly on my side, and both beta version of MPC BE and release version are tested.

Here is the setting on my side:

image

What bothers me though, is when using this MPC Renderer with HDR, it will force turn off HDR option in Windows whenever I quit the MPC BE Player, regardless which states HDR was in Windows setting before MPC is open. It doesn't happen when using madVR.

Aleksoid1978 commented 3 years ago

Auto display HDR on/off - enable/disable system HDR mode.

clsid2 commented 3 years ago

What he means, is that when OS HDR is already enabled when creating the renderer, then it should not disable OS HDR when playback is finished.

Aleksoid1978 commented 3 years ago

For me it’s working. If HDR enable in OS and open HDR video - after close HDR mode stay ON in OS, if open SDR video - HDR mode disable in OS and stay disabled. Using MPC-BE with internal filters.

Aleksoid1978 commented 3 years ago

I also check using LAV Video. So - after open LAV Video set "flag" that's is SDR video - MPC VR off HDR mode in OS, then LAV Video set "flag" that is HDR video, MPC VR on HDR mode in OS and after close "restore" previous state ... SDR mode in OS. Using MPC-BE's internal video decoder all is good.

I will think about what can be done.

clsid2 commented 3 years ago

That sounds like it overwrites the "original" state each time it switches HDR on/off. It should backup the state just once.

int origHDRstate = -1;
// backup:
if (origHDRstate < 0) {
// save original state, set to 0 for normal mode, 1 for HDR mode
}
// restore:
if (origHDRstate >= 0) {
// restore original state, if 1 HDR mode, otherwise normal mode
}
z826540272 commented 3 years ago

I also check using LAV Video. So - after open LAV Video set "flag" that's is SDR video - MPC VR off HDR mode in OS, then LAV Video set "flag" that is HDR video, MPC VR on HDR mode in OS and after close "restore" previous state ... SDR mode in OS. Using MPC-BE's internal video decoder all is good.

I will think about what can be done.

Auto display HDR on/off - enable/disable system HDR mode.

MPC-BE doesnt support Hardware decode when add SVP filter,but this video render cannot work with MPC-HC

Aleksoid1978 commented 3 years ago

Good working in MPC-HC.

clsid2 commented 3 years ago

The renderer works great with latest MPC-HC (1.9.8). You might be using an old version (1.7.13). https://github.com/clsid2/mpc-hc/releases/tag/1.9.8