Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.04k stars 116 forks source link

Deinterlacing not working well on high frequency displays (144 Hz) #45

Closed bobdig closed 6 months ago

bobdig commented 2 years ago

I am a user of MPC-HC and one gripe I have with the now default MPC Video Renderer is how unsmooth the deinterlacing is still looking. I "tested" this with a nvidia 1060 and 3060 mobile on a 144 Hz Screen (monitor and laptop). The result is always the same, with EVR(CP) it is much smoother. I wish we could get some progress with that.

JTGaming commented 6 months ago

Seems fine enough from my testing. I'm guessing you're doing the waiting inside the Render() function itself, right before the call to Present()? Interested to see the code once you push your commit.

Aleksoid1978 commented 6 months ago

Yes - calculate diff and sleep if need just before call present().

NBruderman commented 6 months ago

@JTGaming the commit is out https://github.com/Aleksoid1978/VideoRenderer/commit/a2fb8ea0fd87a7a7eedd26c602a1495ed6efcfa5

JTGaming commented 6 months ago

Seems like the issue is finally fixed. If anyone would like to double-check and confirm that, then this issue could finally be closed.

zhallgato commented 6 months ago

I double-checked, and I can also confirm that the problem is fixed. This issue can be closed.

v0lt commented 6 months ago

I made a slightly modified version. mpcvr-0.7.2.2207_minimizing_sleep_calls_1.zip This version will not call Sleep if there is less than half of the display refresh interval left before presentation time.