Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.06k stars 119 forks source link

brightness does not go brighter than 400 nits when playing content with HLG tonemapping function #97

Closed NathanSakana closed 1 year ago

NathanSakana commented 1 year ago

content in question: https://www.youtube.com/watch?v=j0j-40NrGGU

mpc-be64_iN3boDOwfI shader is 16-235 to 0-255

Aleksoid1978 commented 1 year ago

I don't know how and what to check - but in this test video I see a difference where 400 nits or higher. The metadata is given to the display as 1000 nits.

Well, in fact - windows does not support HLG passthrough, so the renderer does the conversion using HLG -> HDR shaders. Maybe there are not quite accurate calculations or something is missing - I don't know. If someone understands this and makes changes - good.

NathanSakana commented 12 months ago

Hello, just want to update my observation on this issue. I am currently switching my GPU from Polaris to RDNA 3, and because of that, I have already done a clean install of the GPU driver. And for whatever reason, the renderer seems to play HLG content as intended again. I don't know if it is because I swapped my GPU, or I have done a clean install of my GPU driver, but either way, it seems that the issue does not have anything to do with the renderer itself.