Refactoring

[egelja]

Most linters warn on cyclomatic complexity of 10.

terrain::Terrain::get_path_type has a complexity of 25.

Here are all the functions that need to be refactored:

[AlemSnyder]

terrain::Terrain::get_path_type should have at least 3^3 -1 possible outputs. To be honest having a complexity of less than 26 is impressive.

[AlemSnyder]

Message call back is just three switch statements.

Three of those are main type functions.

I think I brought get_first_not below 10.

terrain::Chunk::Chunk is not great, but its three discrete parts.

[AlemSnyder]

Cyclomatic complexity of current main branch.

• [ ] 12 terrain::Chunk::Chunk@11-50@./src/terrain/chunk.cpp
• [x] 25 terrain::Terrain::get_path_type@365-434@./src/terrain/terrain.cpp
• [x] 20 gui::message_callback@41-99@./src/gui/gui_logging.hpp
• [x] 21 entity::generate_mesh@145-367@./src/entity/mesh.hpp

• [x] 13 main@230-296@./src/main.cpp

  There are also three duplicated blocks. Two are in terrain base and deal with grass initialization, the third is in terrain generation. Terrain generation will not be updated until Lua is implemented #17.