search

AleoNet / snarkOS

A Decentralized Operating System for ZK Applications
http://snarkos.org
Apache License 2.0
4.31k stars 2.62k forks source link

[Optimize] Primary and Worker configuration tweaks #3211

Closed raychu86 closed 5 months ago

raychu86 commented 5 months ago

Motivation

This PR updates the configurations with the following changes:

  1. Randomly select transmissions for the worker ping

    • Previously, we would always take the first 5
    • This changes gives a better distribution of transmissions.

  2. Relax the proposal requirement to allow proposals with no transmissions.

    • Blocks with no transactions is already allowed, this relaxes the requirements on the snarkOS side

  3. Reinsert transmissions to the worker if a proposal fails

    • Previously we were erroneously discarding transmissions if the proposal fails, now we keep them around.
vicsn commented 5 months ago

If we don't need transactions anymore in batch proposals, is this also a good moment to remove initialize_transaction_pool (and the commented out code above it, and the --no-dev-txs flag)?