[Bug] If the number of transactions in the network is low, it may cause the network to stop

[elderhammer]

🐛 Bug Report

If the number of transmissions in the network is too small, the validator may not be able to propose normally. If this happens to all validators in the same round, the network will not function properly.

Steps to Reproduce

1. The primary collects transmissions from workers until the number of transmissions in the worker is empty (snarkOS, node/bft/src/primary.rs:483)
2. Update lock_guard to the current round (snarkOS, node/bft/src/primary.rs:542)
3. If the number of transmissions is less than 50, BatchHeader::new() will report an error (snarkVM, ledger/narwhal/batch-header/src/lib.rs:96)
4. This proposal failed and returned
5. If proposed again in this round, it will be judged as expired (snarkOS, node/bft/src/primary.rs:535)

Expected Behavior

When the transmission in the network increases enough, the network successfully proposes.

Your Environment

• snarkOS: 01ea4768ed62d3f1933745568f023fadcf15cdf1

[vicsn]

Thank you for your submission! Before we can review any PRs for this, it would be great if you can:

• share code which reproduces the bug.
• be more precies about what the bug is exactly. Does the network stop or are certain valid proposals rejected?

More pressingly, your step 3 is incorrect. The ensure macro will succeed as long as the number of transmissions is less than or equal to 50. Feel free to close this issue if indeed no longer relevant.