search

AleoNet / snarkOS

A Decentralized Operating System for ZK Applications
http://snarkos.org
Apache License 2.0
4.1k stars 2.57k forks source link

Disable logging to stdout since it is already logged to a file #3285

Closed elderhammer closed 1 month ago

elderhammer commented 1 month ago

Motivation

This PR is to disable logging to stdout, since it already logs to a file. https://github.com/AleoNet/snarkOS/blob/81ca9cf6f923dc8955347b0993beebeaa17161fc/cli/src/helpers/logger.rs#L131 Directly outputting logs to stdout is not convenient for viewing, and the error information is flushed away due to continuous output.

vicsn commented 1 month ago

Although I see and empathize with the reasoning - advising against this PR. Various teams and people are depending on stdout info for quick local testing.

elderhammer commented 1 month ago

Although I see and empathize with the reasoning - advising against this PR. Various teams and people are depending on stdout info for quick local testing.

Ok