Open elderhammer opened 2 weeks ago
I think there are two problems to solve:
@joske can you confirm if this is an issue (and the related PR resolves it?)
I think #3304 should avoid the node getting stuck on big blocks. That said, there's still a deadlock in sync that we haven't found yet.
I don't know about the MAX_TRANSACTIONS
I think #3304 should avoid the node getting stuck on big blocks. That said, there's still a deadlock in sync that we haven't found yet.
I don't know about the MAX_TRANSACTIONS
I've looked at change 3304, which is a change to node/router/src/inbound.rs, but the problem described there is within the BFT module: https://github.com/AleoNet/snarkOS/blob/cf83035ab79907329208a7f4e35d77e8e49d0596/node/bft/src/gateway.rs#L629-L644
The value of MAX_TRANSACTIONS is hardcoded to 1048575, which means that a fake BlockResponse may be filled with 1048575 transactions, which will make deserialization extremely time-consuming.
it's probably a good idea to defer this deserialization to rayon in Gateway too, yes.
🐛 Bug Report
Your Environment
snarkOS Version: cf83035ab79907329208a7f4e35d77e8e49d0596