AleoNet / snarkOS

A Decentralized Operating System for ZK Applications
http://snarkos.org
Apache License 2.0
4.36k stars 2.64k forks source link

[Bug] Most recent `curl-sys` crate update causes SnarkOS build to fail due to SnarkOS MSRV being at `v1.76.0` #3403

Open iamalwaysuncomfortable opened 1 month ago

iamalwaysuncomfortable commented 1 month ago

🐛 Bug Report

The curl-sys library version was recently bumped to 0.4.76 which updated the Rust MSRV in that crate to 1.80.0. This currently causes SnarkOS to fail to build using cargo build or cargo install to fail.

This is resolved if the MSRV in SnarkOS is updated.

Steps to Reproduce

  1. Navigate to the SnarkOS main directory
  2. Execute cargo build or cargo install --path .
  3. The build fails with the error:
error: unsupported output in build script of `curl-sys v0.4.76+curl-8.10.1`: `cargo::rustc-check-cfg=cfg(libcurl_vendored,link_libnghttp2,link_libz,link_openssl,)`
Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

Potential Fixes

zosorock commented 1 month ago

@iamalwaysuncomfortable could you please confirm this is fixed with the merging of #3413?