[HackerOne-2498849] Abort fee earlier in prepare_for_speculate

AleoNet / snarkVM

A Virtual Machine for Zero-Knowledge Executions

https://snarkvm.org

Apache License 2.0

1.08k stars 1.5k forks source link

[HackerOne-2498849] Abort fee earlier in prepare_for_speculate #2452

Closed vicsn closed 6 months ago

vicsn commented 6 months ago

Motivation

Does not close but partially mitigates: https://github.com/AleoHQ/snarkVM/issues/2451

A malicious validator can generate an execution with mostly the same transitions, which will be aborted causing the victim's transaction to be filtered out and dropped.

Test Plan

[x] e2e test succeeded which starts a devnet, syncs, 10 TPS, bonding (no deployments yet).
[x] Unit tests corrected.

Related PRs

This was introduced by: https://github.com/AleoHQ/snarkVM/pull/2428

raychu86 commented 6 months ago

Note that this is a potential breaking change, that may affect the ongoing networks.

The validators being run most likely won't be throwing around these Fee transactions in the honest case, however we need to be sure that nobody ran that as a test case during the operation of the network.