search

AleoNet / snarkVM

A Virtual Machine for Zero-Knowledge Executions
https://snarkvm.org
Apache License 2.0
1.08k stars 1.5k forks source link

Updating Mainnet Beta genesis block for release v0.1.0 #2542

Closed zosorock closed 2 months ago

zosorock commented 2 months ago

Motivation

Updating Mainnet Beta genesis block for release v0.1.0

Related PRs

https://github.com/AleoNet/snarkOS/pull/3393

raychu86 commented 2 months ago

The genesis block's timestamp may optionally be updated via the GENESIS_TIMESTAMP. This was done for CanaryV0 and TestnetV0, but not yet for MainnetV0.

If the change is desired, the genesis block would need to be resampled again (all other fields will be the same).

aleojohn commented 2 months ago

LGTM - w/ exception to timestamp

ghostant-1017 commented 2 months ago

Need to update the MAX_COMMITTEE_SIZE from 15 to 16 https://github.com/AleoNet/snarkVM/blob/mainnet-staging/console/network/src/mainnet_v0.rs#L159

raychu86 commented 2 months ago

Need to update the MAX_COMMITTEE_SIZE from 15 to 16 https://github.com/AleoNet/snarkVM/blob/mainnet-staging/console/network/src/mainnet_v0.rs#L159

@ghostant-1017 This should already be done here - https://github.com/AleoNet/snarkVM/pull/2542/files#diff-020f8a47f91e2989abed49d5aeb48eb194da952cee392de676de5f75b45b1913R159. Please confirm if you see otherwise.

ghostant-1017 commented 2 months ago

Need to update the MAX_COMMITTEE_SIZE from 15 to 16 https://github.com/AleoNet/snarkVM/blob/mainnet-staging/console/network/src/mainnet_v0.rs#L159

@ghostant-1017 This should already be done here - https://github.com/AleoNet/snarkVM/pull/2542/files#diff-020f8a47f91e2989abed49d5aeb48eb194da952cee392de676de5f75b45b1913R159. Please confirm if you see otherwise.

Sorry, I ignored it.

ghostant-1017 commented 2 months ago

Why do we need to set this value to 16? If a new validator bonds, there will be problems, right? There will be 800,000 ACs minted per day, after tens of days, there will be enough ACs to bond as a validator.

raychu86 commented 2 months ago

Why do we need to set this value to 16? If a new validator bonds, there will be problems, right?

There is now 16 validators in the genesis committee set. The implications are the same as before when there was 15, except now the genesis has one additional.

hairtail commented 2 months ago

Wen can we get this PR approved and merged hahaha

ghostant-1017 commented 2 months ago

Why do we need to set this value to 16? If a new validator bonds, there will be problems, right? There will be 800,000 ACs minted per day, after tens of days, there will be enough ACs to bond as a validator.

Yes, I mean if we have more than 16 validators after ten days of mainnet launch .

raychu86 commented 2 months ago

All bond_public calls for new validators past the 16 will be safely aborted. This maximum value will need to be updated before new validators can safely join.

ghostant-1017 commented 2 months ago

All bond_public calls for new validators past the 16 will be safely aborted. This maximum value will need to be updated before new validators can safely join.

Thank you Raymond! I see the logic.