search

Aleph-Alpha / ts-rs

Generate TypeScript bindings from Rust types
MIT License
1.15k stars 115 forks source link

add "as" derive helper attribute #174

Closed josema03 closed 9 months ago

josema03 commented 1 year ago

This implements the feature requested in the following issue: https://github.com/Aleph-Alpha/ts-rs/issues/113

Please take a look at it and let me know if I need to make any other change to have it merged.

escritorio-gustavo commented 9 months ago

I have fixed the merge conflict, but I haven't passed the fix through the compiler, needs to be checked

NyxCode commented 9 months ago

I love it! Thanks @josema03, and thank you so much @escritorio-gustavo for putting in the time to clean this up!
Once it's ready, I think this would be a really cool addition.

escritorio-gustavo commented 9 months ago

Hey @NyxCode! I'm having some trouble merging this with #213, how should these PRs interact in macros/types/named.rs

Edit: I think I got it working (CI passing) but would still like to have you take another look at this file before merging

NyxCode commented 9 months ago

Hey @NyxCode! I'm having some trouble merging this with #213, how should these PRs interact in macros/types/named.rs

Edit: I think I got it working (CI passing) but would still like to have you take another look at this file before merging

Sure, lemme take a look at that!

NyxCode commented 9 months ago

From my side, this is ready to merge! @escritorio-gustavo Can you take a last look & merge this? <3